[StaticAnalyzer] Use llvm::find_if (NFC) #169237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified with llvm-use-ranges.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) ChangesIdentified with llvm-use-ranges. Full diff: https://github.com/llvm/llvm-project/pull/169237.diff 1 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp b/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
index 6673f2f319c0e..aafd8d45537e3 100644
--- a/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
+++ b/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
@@ -202,11 +202,10 @@ SarifDiagnostics::createResult(const PathDiagnostic *Diag,
// Find the HTML report that was generated for this issue, if one exists.
PDFileEntry::ConsumerFiles *Files = FM->getFiles(*Diag);
if (Files) {
- auto HtmlFile =
- std::find_if(Files->cbegin(), Files->cend(), [](auto &File) {
- return File.first == HTML_DIAGNOSTICS_NAME;
- });
- if (HtmlFile != Files->cend()) {
+ auto HtmlFile = llvm::find_if(*Files, [](const auto &File) {
+ return File.first == HTML_DIAGNOSTICS_NAME;
+ });
+ if (HtmlFile != Files->end()) {
SmallString<128> HtmlReportPath =
llvm::sys::path::parent_path(OutputFile);
llvm::sys::path::append(HtmlReportPath, HtmlFile->second);
|
Member
|
@llvm/pr-subscribers-clang-static-analyzer-1 Author: Kazu Hirata (kazutakahirata) ChangesIdentified with llvm-use-ranges. Full diff: https://github.com/llvm/llvm-project/pull/169237.diff 1 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp b/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
index 6673f2f319c0e..aafd8d45537e3 100644
--- a/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
+++ b/clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
@@ -202,11 +202,10 @@ SarifDiagnostics::createResult(const PathDiagnostic *Diag,
// Find the HTML report that was generated for this issue, if one exists.
PDFileEntry::ConsumerFiles *Files = FM->getFiles(*Diag);
if (Files) {
- auto HtmlFile =
- std::find_if(Files->cbegin(), Files->cend(), [](auto &File) {
- return File.first == HTML_DIAGNOSTICS_NAME;
- });
- if (HtmlFile != Files->cend()) {
+ auto HtmlFile = llvm::find_if(*Files, [](const auto &File) {
+ return File.first == HTML_DIAGNOSTICS_NAME;
+ });
+ if (HtmlFile != Files->end()) {
SmallString<128> HtmlReportPath =
llvm::sys::path::parent_path(OutputFile);
llvm::sys::path::append(HtmlReportPath, HtmlFile->second);
|
steakhal
approved these changes
Nov 23, 2025
kazutakahirata
deleted the
cleanup_20251123_clang_tidy_llvm-use-ranges_clang
branch
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
Identified with llvm-use-ranges.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
Identified with llvm-use-ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified with llvm-use-ranges.